coated textures in snow area only#288
coated textures in snow area only#288Noa3 wants to merge 3 commits intoComplementaryDevelopment:mainfrom
Conversation
Co-authored-by: Noa3 <8495084+Noa3@users.noreply.github.com>
Add snow-only mode for coated textures
There was a problem hiding this comment.
Pull request overview
Adds an optional “snow-only” mode for coated texture overlays, limiting the effect to snowy biomes via the existing inSnowy uniform (with smooth transitions).
Changes:
- Introduces
COATED_TEXTURES_SNOW_ONLY(off by default) as a new shader define. - Gates coated texture application (early-out + intensity scaling) based on
inSnowy. - Exposes the toggle in the shader options UI and adds English label/tooltip text.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
shaders/shaders.properties |
Adds COATED_TEXTURES_SNOW_ONLY to the IPBR settings menu so users can toggle it. |
shaders/lib/materials/materialMethods/coatedTextures.glsl |
Applies snow-only gating using inSnowy (early return + noiseFactor scaling). |
shaders/lib/common.glsl |
Declares the new optional define (commented out by default). |
shaders/lang/en_US.lang |
Adds user-facing option label and tooltip for the new toggle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| option.COATED_TEXTURES.comment=Adds auto-generated dusty details to textures. §e[*]§r RP Support option must be set to Integrated PBR+. | ||
|
|
||
| option.COATED_TEXTURES_SNOW_ONLY=Snow Only Coating | ||
| option.COATED_TEXTURES_SNOW_ONLY.comment=When enabled, coated textures only appear in snowy biomes or areas with snowfall. §e[*]§r Requires Coated Textures to be enabled. |
There was a problem hiding this comment.
The tooltip says “snowy biomes or areas with snowfall”, but the implementation uses the inSnowy uniform which is derived from biome_precipitation == 2 (snow precipitation type). That corresponds to snowy biomes, not necessarily places where it is currently snowing / can snow due to local temperature/altitude. Consider rewording the tooltip to match the actual behavior (e.g., “biomes with snow precipitation”).
| option.COATED_TEXTURES_SNOW_ONLY.comment=When enabled, coated textures only appear in snowy biomes or areas with snowfall. §e[*]§r Requires Coated Textures to be enabled. | |
| option.COATED_TEXTURES_SNOW_ONLY.comment=When enabled, coated textures only appear in biomes with snow precipitation. §e[*]§r Requires Coated Textures to be enabled. |
Add snow-only mode for coated textures
Adds
COATED_TEXTURES_SNOW_ONLYoption that restricts coated texture overlay to snowy biomes, using the existinginSnowyuniform for smooth biome-based transitions.shaders/lib/common.glsl: New//#define COATED_TEXTURES_SNOW_ONLY(off by default)shaders/lib/materials/materialMethods/coatedTextures.glsl: Early-out andnoiseFactorscaling gated oninSnowy:shaders/shaders.properties: Added toIPBR_SETTINGSmenu alongsideCOATED_TEXTURESshaders/lang/en_US.lang: Option label and tooltip